test.py: First step towards support of caching dart2js compilations across runtimes

tools/testing/dart/test_options.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_options_parser;
 
 import "dart:io";
 import "dart:math";
 import "drt_updater.dart";
 import "test_suite.dart";
@@ skipping 21 matching lines @@
   List<String> keys;
   List<String> values;
   var defaultValue;
   String type;
 }
 
 /**
  * Parser of test options.
  */
 class TestOptionsParser {
-  String specialCommandHelp =
-"""
-Special command support. Wraps the command line in
-a special command. The special command should contain
-an '@' character which will be replaced by the normal
-command executable.
-
-For example if the normal command line that will be executed
-is 'dart file.dart' and you specify special command
-'python -u valgrind.py @ suffix' the final command will be
-'python -u valgrind.py dart suffix file.dart'""";
-
   /**
    * Creates a test options parser initialized with the known options.
    */
   TestOptionsParser() {
     _options =
         [ new _TestOptionSpecification(
               'mode',
               'Mode in which to run the tests',
               ['-m', '--mode'],
               ['all', 'debug', 'release'],
@@ skipping 157 matching lines @@
               false,
               'bool'),
           new _TestOptionSpecification(
               'list',
               'List tests only, do not run them',
               ['--list'],
               [],
               false,
               'bool'),
           new _TestOptionSpecification(
-              'valgrind',
-              'Run tests through valgrind',
-              ['--valgrind'],
-              [],
-              false,
-              'bool'),
-          new _TestOptionSpecification(
-              'special-command',
-              specialCommandHelp,
-              ['--special-command'],
-              [],
-              ''),
-          new _TestOptionSpecification(
               'time',
               'Print timing information after running tests',
               ['--time'],
               [],
               false,
               'bool'),
           new _TestOptionSpecification(
               'dart',
               'Path to dart executable',
               ['--dart'],
@@ skipping 319 matching lines @@
    * into a list of configurations with exactly one value per key.
    */
   List<Map> _expandConfigurations(Map configuration) {
     // Expand the pseudo-values such as 'all'.
     if (configuration['arch'] == 'all') {
       configuration['arch'] = 'ia32,x64,simarm,simmips';
     }
     if (configuration['mode'] == 'all') {
       configuration['mode'] = 'debug,release';
     }
-    if (configuration['valgrind']) {

[ricow1, 2013/07/30 09:30:11]

Could you file a bug to re-add this functionality and ask on vm list if anybody
is using it?

-      // TODO(ager): Get rid of this when there is only one checkout and
-      // we don't have to special case for the runtime checkout.
-      File valgrindFile = new File('runtime/tools/valgrind.py');
-      if (!valgrindFile.existsSync()) {
-        valgrindFile = new File('../runtime/tools/valgrind.py');
-      }
-      String valgrind = valgrindFile.fullPathSync();
-      configuration['special-command'] = 'python -u $valgrind @';
-    }
 
     // Use verbose progress indication for verbose output unless buildbot
     // progress indication is requested.
     if (configuration['verbose'] && configuration['progress'] != 'buildbot') {
       configuration['progress'] = 'verbose';
     }
 
     // Create the artificial negative options that test status files
     // expect.
     configuration['unchecked'] = !configuration['checked'];
@@ skipping 183 matching lines @@
         return option;
       }
     }
     print('Unknown test option $name');
     exit(1);
   }
 
 
   List<_TestOptionSpecification> _options;
 }