Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2100093002: Fix behavior of return on yield*. (Closed)

Created:
4 years, 5 months ago by neis
Modified:
4 years, 5 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix behavior of return on yield*. When calling the return method on a generator suspended inside a yield*, yield* in turn calls return on its iterable. If this results in a "done" iterator, yield* must return immediately, thus terminating the generator. For some reason, we didn't terminate the generator but continued right after the yield*. R=adamk@chromium.org BUG=v8:5131 Committed: https://crrev.com/6dffb078048a8ff8c000ada468b86689cdcc82f8 Cr-Commit-Position: refs/heads/master@{#37310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M src/parsing/parser.cc View 3 chunks +30 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/function-sent.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/generators.js View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/generators-turbo.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
neis
4 years, 5 months ago (2016-06-27 09:02:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100093002/1
4 years, 5 months ago (2016-06-27 10:36:46 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 11:00:19 UTC) #5
adamk
lgtm
4 years, 5 months ago (2016-06-27 18:07:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100093002/1
4 years, 5 months ago (2016-06-28 07:06:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 07:09:04 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 07:11:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dffb078048a8ff8c000ada468b86689cdcc82f8
Cr-Commit-Position: refs/heads/master@{#37310}

Powered by Google App Engine
This is Rietveld 408576698