Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2100073002: [snapshot] revisit snapshot API. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[snapshot] revisit snapshot API. This part of the snapshot API should not be in use yet, so we can still change this. The motivation for this change is: - Use MaybeHandle where reasonable. - Remove ambiguity: when we use index to create context from snapshot, we should not have a silent fallback if snapshot is not available. - Symmetry: rename to Context::FromSnapshot to mirror templates. R=jochen@chromium.org BUG=chromium:617892 Committed: https://crrev.com/872c461b0003f0d453afcbd3c166faeb132293f8 Cr-Commit-Position: refs/heads/master@{#37334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -47 lines) Patch
M include/v8.h View 3 chunks +11 lines, -4 lines 0 comments Download
M src/api.cc View 4 chunks +31 lines, -11 lines 0 comments Download
M src/snapshot/snapshot.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 7 chunks +16 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
4 years, 5 months ago (2016-06-27 07:46:09 UTC) #1
Yang
On 2016/06/27 07:46:09, Yang wrote: friendly ping :)
4 years, 5 months ago (2016-06-28 06:06:32 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-28 13:12:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100073002/1
4 years, 5 months ago (2016-06-28 13:18:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 13:47:48 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 13:48:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/872c461b0003f0d453afcbd3c166faeb132293f8
Cr-Commit-Position: refs/heads/master@{#37334}

Powered by Google App Engine
This is Rietveld 408576698