[Offline pages] Filter out pages cached by different tabs on tab helper

chrome/browser/android/offline_pages/offline_page_tab_helper.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_
 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "components/offline_pages/offline_page_types.h"
@@ skipping 37 matching lines @@
       content::NavigationHandle* navigation_handle) override;
   void DidFinishNavigation(
       content::NavigationHandle* navigation_handle) override;
 
   void RedirectToOnline(const GURL& from_url,
                         const OfflinePageItem* offline_page);
   void TryRedirectToOffline(RedirectReason redirect_reason,
                             const GURL& from_url,
                             const OfflinePageItem* offline_page);
 
+  void GetBestPageAndTryRedirect(const GURL& online_url,

[Dmitry Titov, 2016/06/27 22:06:04]

These two named almost the same. Consider renaming a bit, to make it clearer
(only say what they actually do):
GetBastPageAndTryRedirect -> StartRedirectToOfflinePage
SelectBestPageAndTryRedirect -> SelectBestPageToRedirect

[fgorski, 2016/06/27 22:40:09]

Done.

+                                 RedirectReason reason);
+  void SelectBestPageAndTryRedirect(RedirectReason reason,
+                                    const GURL& online_url,
+                                    const MultipleOfflinePageItemResult& pages);
+
   void Redirect(const GURL& from_url, const GURL& to_url);
 
   // Iff the tab we are associated with is redirected to an offline page,
   // |offline_page_| will be non-null.  This can be used to synchronously ask
   // about the offline state of the current web contents.
   std::unique_ptr<OfflinePageItem> offline_page_;
   base::WeakPtrFactory<OfflinePageTabHelper> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflinePageTabHelper);
 };
 
 }  // namespace offline_pages
 
 #endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_