Issue 210004: Fix the deadlock when Flash tries to make WMP full screen. This is a one-off...

Issue 210004: Fix the deadlock when Flash tries to make WMP full screen. This is a one-off... (Closed)

Created:
11 years, 3 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix the deadlock when Flash tries to make WMP full screen. This is a one-off solution that detects this case and returns the reply to the sync message before calling WMP. I don't think this is a generic problem, since we haven't seen it before, and the generic solutions have too many side-effects. BUG=15985 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26521

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -19 lines)			Patch
M	chrome/plugin/npobject_stub.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/plugin/npobject_stub.cc	View	1 2 3	4 chunks	+26 lines, -5 lines	0 comments	Download
M	chrome/plugin/plugin_thread.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_constants_win.h	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_list_win.cc	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl_win.cc	View	1 2 3	3 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jam

I would love to add a test, but not sure how? To trigger this, the ...

11 years, 3 months ago (2009-09-17 21:28:18 UTC) #4

iyengar

This test would have to run as part of interactive_ui_tests. You can simulate mouse clicks, ...

11 years, 3 months ago (2009-09-17 21:46:32 UTC) #5

jam

11 years, 3 months ago (2009-09-17 22:52:31 UTC) #6

I tried to look into this, but I just don't see this happening as a
non-flakey test.
fullScreen mode can only be entered when the video is playing.  If we try to
call it before the video starts playing, it won't do anything.  If we wait
too long, then the video will finish playing.  It's hard to pick a number
that'll work consistently on all hardware and not be flakey.  Also figuring
out when it's full screen so that we can turn it off and complete the test
seems like it'll require scrapping windows, which traditionally has been a
source of flakiness.  So I'm sadly inclined to not add a test.

On Thu, Sep 17, 2009 at 2:46 PM, Anantanarayanan Iyengar <iyengar@google.com
> wrote:

> This test would have to run as part of interactive_ui_tests. You can
> simulate mouse clicks, etc, with the SendInput function.
> Thanks
> Ananta
>
>
> On Thu, Sep 17, 2009 at 2:27 PM, John Abd-El-Malek <jam@chromium.org>wrote:
>
>> I would love to add a test, but not sure how?  To trigger this, the Flash
>> control needs to be clicked with the mouse so that it has focus/activation.
>>  Do you know of a way to simulate this using a test?
>>
>>
>> On Thu, Sep 17, 2009 at 11:29 AM, <ananta@chromium.org> wrote:
>>
>>> LGTM. Please look into a test case for this if possible.
>>>
>>>
>>>
>>>
>>> http://codereview.chromium.org/210004
>>>
>>
>>
>

Expand Messages | Collapse Messages