Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 210003002: Web MIDI API renaming: the second step of three step changes (Closed)

Created:
6 years, 9 months ago by Takashi Toyoshima
Modified:
6 years, 9 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Web MIDI API renaming: the second step of three step changes To update Web MIDI API spec, we decided to rename functions having SysEx to sysex. This affects blink API and needs update Chromium side embedder implementations. Here are a series of changes on this renaming. 1. https://codereview.chromium.org/208243014/ 2. this change 3. https://codereview.chromium.org/208423016/ BUG=349538 TEST=LayoutTests/webmidi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259560

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Patch Set 3 : (rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M content/renderer/media/midi_dispatcher.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/media/midi_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Takashi Toyoshima
Hi Jochen, Can you take a look? The first blink side change is reviewed by ...
6 years, 9 months ago (2014-03-24 13:49:31 UTC) #1
Takashi Toyoshima
FYI. The first patch is landed as blink r169909.
6 years, 9 months ago (2014-03-25 05:55:33 UTC) #2
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/210003002/diff/1/content/renderer/media/midi_dispatcher.h File content/renderer/media/midi_dispatcher.h (right): https://codereview.chromium.org/210003002/diff/1/content/renderer/media/midi_dispatcher.h#newcode37 content/renderer/media/midi_dispatcher.h:37: const blink::WebMIDIPermissionRequest& request) OVERRIDE; we usually ...
6 years, 9 months ago (2014-03-26 10:32:06 UTC) #3
Takashi Toyoshima
https://codereview.chromium.org/210003002/diff/1/content/renderer/media/midi_dispatcher.h File content/renderer/media/midi_dispatcher.h (right): https://codereview.chromium.org/210003002/diff/1/content/renderer/media/midi_dispatcher.h#newcode37 content/renderer/media/midi_dispatcher.h:37: const blink::WebMIDIPermissionRequest& request) OVERRIDE; On 2014/03/26 10:32:07, jochen wrote: ...
6 years, 9 months ago (2014-03-26 10:50:25 UTC) #4
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 9 months ago (2014-03-26 10:50:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/210003002/60001
6 years, 9 months ago (2014-03-26 10:51:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 11:12:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-26 11:12:39 UTC) #8
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 9 months ago (2014-03-26 12:20:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/210003002/60001
6 years, 9 months ago (2014-03-26 12:20:25 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 12:51:05 UTC) #11
Message was sent while issue was closed.
Change committed as 259560

Powered by Google App Engine
This is Rietveld 408576698