Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2100023002: X87: [builtins] Introduce proper Float64Log2 and Float64Log10 operators. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce proper Float64Log2 and Float64Log10 operators. port d9bf520a22924381a1da7e85d5d0063245a3c6c1 (r37035) original commit message: BUG= Committed: https://crrev.com/513240bfdffa9acc619dc4e637f10942ba4d84c0 Cr-Commit-Position: refs/heads/master@{#37268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 04:38:25 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 05:03:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100023002/1
4 years, 5 months ago (2016-06-27 05:23:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 05:40:31 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 05:43:45 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/513240bfdffa9acc619dc4e637f10942ba4d84c0
Cr-Commit-Position: refs/heads/master@{#37268}

Powered by Google App Engine
This is Rietveld 408576698