Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2100003002: X87: Fix arguments object stubs for large arrays. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Fix arguments object stubs for large arrays. port e95cfafb67dba67eb7c541d97f5e69f8280df771 (r36917) original commit message: This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no longer assume that the strict arguments object being allocated will fit into new-space. The case where said object needs to move to large object space is now handled in the runtime. BUG= Committed: https://crrev.com/785bb8a3edb4f41d85dc0b3a1993e21c06288289 Cr-Commit-Position: refs/heads/master@{#37263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M src/x87/code-stubs-x87.cc View 4 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 02:10:07 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 02:11:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100003002/1
4 years, 5 months ago (2016-06-27 02:21:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 02:43:33 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 02:46:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/785bb8a3edb4f41d85dc0b3a1993e21c06288289
Cr-Commit-Position: refs/heads/master@{#37263}

Powered by Google App Engine
This is Rietveld 408576698