Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2099983004: Revert of Refactor CreateApiFunction (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Refactor CreateApiFunction (patchset #2 id:20001 of https://codereview.chromium.org/2095953002/ ) Reason for revert: [Sheriff] Changes a layout test. Please rebase upstream if intended: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7742 Original issue's description: > Refactor CreateApiFunction > > BUG= > > Committed: https://crrev.com/705574970f3899a6eda0c61130c8c31693df4039 > Cr-Commit-Position: refs/heads/master@{#37290} TBR=jochen@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/55f0b92d855e2e86414385b3b40b90847adfbbb5 Cr-Commit-Position: refs/heads/master@{#37299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -89 lines) Patch
M src/accessors.cc View 3 chunks +25 lines, -4 lines 0 comments Download
M src/api-natives.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/api-natives.cc View 3 chunks +77 lines, -46 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +21 lines, -13 lines 0 comments Download
M src/factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +22 lines, -9 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Refactor CreateApiFunction
4 years, 5 months ago (2016-06-27 17:32:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099983004/1
4 years, 5 months ago (2016-06-27 17:32:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 18:04:09 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 18:05:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55f0b92d855e2e86414385b3b40b90847adfbbb5
Cr-Commit-Position: refs/heads/master@{#37299}

Powered by Google App Engine
This is Rietveld 408576698