Issue 209993002: Parser fix: check allow_harmony_scoping() instead of FLAG_harmony_scoping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209993002: Parser fix: check allow_harmony_scoping() instead of FLAG_harmony_scoping. (Closed)

Created:
6 years, 9 months ago by marja

Modified:
6 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Parser fix: check allow_harmony_scoping() instead of FLAG_harmony_scoping. Without this fix, ParserBase::set_allow_harmony_scoping() and the kAllowHarmonyScoping in test-parsing.cc don't have any effect, and we end up not running the tests with harmony scoping allowed. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20200

Patch Set 1 #

Patch Set 2 : preparser too #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -15 lines)			Patch
	M	src/parser.cc	View		10 chunks	+13 lines, -12 lines	0 comments	Download
	M	src/preparser.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

marja

6 years, 9 months ago (2014-03-24 14:42:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20200 (presubmit successful).

Expand Messages | Collapse Messages