Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2099923002: Add missing instance types in switch statement. (Closed)

Created:
4 years, 6 months ago by Franzi
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing instance types in switch statement. BUG=623021 Committed: https://crrev.com/b0016f6dc64279ee186256b2d7c0455b4985437d Cr-Commit-Position: refs/heads/master@{#37276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/objects-printer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Franzi
Forgot to add the new instance types to this switch statement. PTAL. Thanks, Franzi
4 years, 6 months ago (2016-06-25 14:02:09 UTC) #2
Igor Sheludko
lgtm
4 years, 5 months ago (2016-06-27 07:42:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099923002/1
4 years, 5 months ago (2016-06-27 07:48:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 08:14:00 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 08:15:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0016f6dc64279ee186256b2d7c0455b4985437d
Cr-Commit-Position: refs/heads/master@{#37276}

Powered by Google App Engine
This is Rietveld 408576698