Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: services/ui/ws/frame_generator.cc

Issue 2099893002: Mus: Fixes rendering of transparent containers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix namespace comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/ws/frame_generator.h ('k') | services/ui/ws/frame_generator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/frame_generator.cc
diff --git a/services/ui/ws/frame_generator.cc b/services/ui/ws/frame_generator.cc
index aea380b64ecbc2158d084fb10a0c4cbd31f2a232..e77b95740d0bfd2919189942c434146c36a6bb0e 100644
--- a/services/ui/ws/frame_generator.cc
+++ b/services/ui/ws/frame_generator.cc
@@ -119,7 +119,6 @@ void FrameGenerator::DrawWindowTree(
const gfx::Rect absolute_bounds =
window->bounds() + parent_to_root_origin_offset;
std::vector<ServerWindow*> children(window->GetChildren());
- // TODO(rjkroege, fsamuel): Make sure we're handling alpha correctly.
const float combined_opacity = opacity * window->opacity();
for (auto it = children.rbegin(); it != children.rend(); ++it) {
DrawWindowTree(pass, *it, absolute_bounds.OffsetFromOrigin(),
@@ -148,7 +147,7 @@ void FrameGenerator::DrawWindowTree(
bounds_at_origin.size() /* layer_bounds */,
bounds_at_origin /* visible_layer_bounds */,
bounds_at_origin /* clip_rect */, false /* is_clipped */,
- window->opacity(), SkXfermode::kSrcOver_Mode,
+ combined_opacity, SkXfermode::kSrcOver_Mode,
0 /* sorting-context_id */);
auto quad = pass->CreateAndAppendDrawQuad<cc::SurfaceDrawQuad>();
quad->SetAll(sqs, bounds_at_origin /* rect */,
@@ -169,7 +168,7 @@ void FrameGenerator::DrawWindowTree(
bounds_at_origin.size() /* layer_bounds */,
bounds_at_origin /* visible_layer_bounds */,
bounds_at_origin /* clip_rect */, false /* is_clipped */,
- window->opacity(), SkXfermode::kSrcOver_Mode,
+ combined_opacity, SkXfermode::kSrcOver_Mode,
0 /* sorting-context_id */);
auto quad = pass->CreateAndAppendDrawQuad<cc::SurfaceDrawQuad>();
« no previous file with comments | « services/ui/ws/frame_generator.h ('k') | services/ui/ws/frame_generator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698