Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2099843002: v8 clang/win: Stop passing /FIIntrin.h (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

v8 clang/win: Stop passing /FIIntrin.h See https://codereview.chromium.org/2076483002 for a lengthy reasoning. The two mysterious files called out there were in boringssl and nacl, so for v8 this should be a complete no-op. BUG=chromium:592745 Committed: https://crrev.com/8c8a9f18fbcfbc7e030bc64d9ebb4ed2829588c5 Cr-Commit-Position: refs/heads/master@{#37272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M gypfiles/standalone.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 6 months ago (2016-06-24 21:01:18 UTC) #2
Michael Achenbach
lgtm
4 years, 5 months ago (2016-06-27 07:09:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099843002/1
4 years, 5 months ago (2016-06-27 07:09:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 07:34:13 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 07:34:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c8a9f18fbcfbc7e030bc64d9ebb4ed2829588c5
Cr-Commit-Position: refs/heads/master@{#37272}

Powered by Google App Engine
This is Rietveld 408576698