Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2099833002: For a range surrounding a node, set selection index to 0. (Closed)

Created:
4 years, 6 months ago by David Tseng
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

For a range surrounding a node, set selection index to 0. ChromeVox already tries setting selection to its range when navigating. In the past, we passed -1 for the index (aka anchor/focus offsets), which had no effect. After this change, within content editables, we sync our current range for commands that move it such as next heading. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bcac09c87ee222e44a9bc1806315f762fcb29c91 Cr-Commit-Position: refs/heads/master@{#402909}

Patch Set 1 #

Patch Set 2 : Update test #

Patch Set 3 : Add simple test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (15 generated)
David Tseng
4 years, 5 months ago (2016-06-28 17:57:34 UTC) #4
dmazzoni
lgtm
4 years, 5 months ago (2016-06-28 17:58:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099833002/1
4 years, 5 months ago (2016-06-28 17:59:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/235837)
4 years, 5 months ago (2016-06-28 18:26:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099833002/20001
4 years, 5 months ago (2016-06-28 19:27:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/235942)
4 years, 5 months ago (2016-06-28 19:53:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099833002/20001
4 years, 5 months ago (2016-06-29 17:37:25 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:56:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099833002/40001
4 years, 5 months ago (2016-06-29 18:10:29 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 19:51:14 UTC) #24
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bcac09c87ee222e44a9bc1806315f762fcb29c91 Cr-Commit-Position: refs/heads/master@{#402909}
4 years, 5 months ago (2016-06-29 19:52:51 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:52:52 UTC) #27
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698