mash: Migrate some system user files to common.

mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.* ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.* ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.* ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.* ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5
Cr-Commit-Position: refs/heads/master@{#401975}

[msw, 2016-06-24 19:26:58]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 19:27:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-06-24 20:01:51]

Description was changed from

==========
mash: Migrate some system user files to common.

BUG=619636
==========

to

==========
mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.*
ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2016-06-24 20:01:51]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-06-24 20:04:28]

Hey James, please take a look; thanks!

https://codereview.chromium.org/2099793002/diff/20001/ash/root_window_control...
File ash/root_window_controller.h (right):

https://codereview.chromium.org/2099793002/diff/20001/ash/root_window_control...
ash/root_window_controller.h:57: enum class LoginStatus;
WDYT about these forward decls? I'm on the fence...

[msw, 2016-06-24 20:04:38]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 20:05:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-06-24 20:18:53]

LGTM

https://codereview.chromium.org/2099793002/diff/20001/ash/common/system/user/...
File ash/common/system/user/login_status.cc (right):

https://codereview.chromium.org/2099793002/diff/20001/ash/common/system/user/...
ash/common/system/user/login_status.cc:29:
WmShell::Get()->GetSessionStateDelegate()->NumberOfLoggedInUsers() > 1
aside: At some point the SessionStateDelegate will be owned by WmShell, in which
case the accessor should be session_state_delegate() { return
session_state_delegate_.get(); }

I wonder if we should rename GetSessionStateDelegate() to
session_state_delegate() (intentionally violating the style guide for virtual
methods) such that we eventually end up in the right state.

https://codereview.chromium.org/2099793002/diff/20001/ash/root_window_control...
File ash/root_window_controller.h (right):

https://codereview.chromium.org/2099793002/diff/20001/ash/root_window_control...
ash/root_window_controller.h:57: enum class LoginStatus;
On 2016/06/24 20:04:28, msw wrote:
> WDYT about these forward decls? I'm on the fence...

Either #include "ash/common/login_status.h" or forward declare, either way is
fine with me.

But let's not include "ash/system/user/login_status.h" just to get the enum.

[msw, 2016-06-24 20:25:26]

Description was changed from

==========
mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.*
ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.*
ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[msw, 2016-06-24 20:25:27]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-06-24 20:26:46]

+TBR Scott for chrome OWNERS (just updates include paths).

https://codereview.chromium.org/2099793002/diff/20001/ash/common/system/user/...
File ash/common/system/user/login_status.cc (right):

https://codereview.chromium.org/2099793002/diff/20001/ash/common/system/user/...
ash/common/system/user/login_status.cc:29:
WmShell::Get()->GetSessionStateDelegate()->NumberOfLoggedInUsers() > 1
On 2016/06/24 20:18:53, James Cook wrote:
> aside: At some point the SessionStateDelegate will be owned by WmShell, in
which
> case the accessor should be session_state_delegate() { return
> session_state_delegate_.get(); }
> 
> I wonder if we should rename GetSessionStateDelegate() to
> session_state_delegate() (intentionally violating the style guide for virtual
> methods) such that we eventually end up in the right state.

I'd rather punt until we rename the function (or even later with a deprecated
GetSessionStateDelegate() and a dedicated function rename CL).

https://codereview.chromium.org/2099793002/diff/20001/ash/root_window_control...
File ash/root_window_controller.h (right):

https://codereview.chromium.org/2099793002/diff/20001/ash/root_window_control...
ash/root_window_controller.h:57: enum class LoginStatus;
On 2016/06/24 20:18:53, James Cook wrote:
> On 2016/06/24 20:04:28, msw wrote:
> > WDYT about these forward decls? I'm on the fence...
> 
> Either #include "ash/common/login_status.h" or forward declare, either way is
> fine with me.
> 
> But let's not include "ash/system/user/login_status.h" just to get the enum.

For sure, and I'd totally forward declare a class then include the header in the
cc file, but I'm just not used to doing the same with enums, and it feels a
little silly, but I'll leave the forward decls as they are in this patch set.

[commit-bot: I haz the power, 2016-06-24 21:12:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 21:12:09]

Dry run: This issue passed the CQ dry run.

[msw, 2016-06-24 21:17:38]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-06-24 21:18:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 21:23:59]

Description was changed from

==========
mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.*
ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.*
ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-06-24 21:24:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-24 21:28:43]

Description was changed from

==========
mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.*
ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.*
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.*
ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5
Cr-Commit-Position: refs/heads/master@{#401975}
==========

[commit-bot: I haz the power, 2016-06-24 21:28:44]

Patchset 2 (id:??) landed as
https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5
Cr-Commit-Position: refs/heads/master@{#401975}