Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2099773004: ios: Stop passing -Wno-deprecated-declarations for host builds. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ios: Stop passing -Wno-deprecated-declarations for host builds. ios used to force a deployment target of OS X 10.7 before we used that for chrome/mac builds. Hence, iOS used to get deprecation warnings since we hadn't cleaned up the mac code for a 10.7 deployment target yet. Now that we use the same deployment target for chrome/mac and iOS host builds, suppressing deprecation warnings in iOS builds is no longer needed. No behavior change. BUG=none Committed: https://crrev.com/121329afa514ffa8a976d2eea4ced9824c6380cb Cr-Commit-Position: refs/heads/master@{#401994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
as far as i can tell, this block never got ported to gn.
4 years, 6 months ago (2016-06-24 21:12:40 UTC) #2
Robert Sesek
lgtm
4 years, 6 months ago (2016-06-24 21:13:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099773004/1
4 years, 6 months ago (2016-06-24 21:15:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 22:13:14 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 22:15:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/121329afa514ffa8a976d2eea4ced9824c6380cb
Cr-Commit-Position: refs/heads/master@{#401994}

Powered by Google App Engine
This is Rietveld 408576698