[TTS] Update Tap counters to compensate for Quick Answers.

[TTS] Update Tap counters to compensate for Quick Answers.

When a Tap causes a Quick Answer that shows a caption with doesAnswer,
the user has no real need to open the panel.

This change counts Answers since the last open and uses them to compensate
for Taps without any panel open so we don't stop resolving and preloading
(which would cause subsequent Quick Answers to not appear automatically).

BUG=622160, 609924
Committed: https://crrev.com/210d15f8993fa63424af4cfefd9678c4995e647f
Cr-Commit-Position: refs/heads/master@{#402351}

[Donn Denman, 2016-06-25 02:25:13]

donnd@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[Donn Denman, 2016-06-25 02:25:14]

Pedro, PTAL.

Ideally it won't be too late to merge this in to 52 to help with Quick Answers.

[Donn Denman, 2016-06-25 02:28:14]

Description was changed from

==========
[TTS] Update Tap counters to compensate for Quick Answers.

When a Tap causes a Quick Answer that shows a caption with doesAnswer,
the user has no real need to open the panel.

This change counts Answers since the last open and uses them to compensate
for Taps without any panel open so we don't stop resolving and preloading
(which would cause subsequent Quick Answers to not appear automatically).

BUG=609924
==========

to

==========
[TTS] Update Tap counters to compensate for Quick Answers.

When a Tap causes a Quick Answer that shows a caption with doesAnswer,
the user has no real need to open the panel.

This change counts Answers since the last open and uses them to compensate
for Taps without any panel open so we don't stop resolving and preloading
(which would cause subsequent Quick Answers to not appear automatically).

BUG=622160,609924
==========

[twellington, 2016-06-27 18:46:39]

twellington@google.com changed reviewers:
+ twellington@google.com

[twellington, 2016-06-27 18:46:40]

https://chromiumcodereview.appspot.com/2099753003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java
(right):

https://chromiumcodereview.appspot.com/2099753003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java:545:
return getTapCount() -
mPreferenceManager.getContextualSearchTapQuickAnswerCount()
Do we need to do something like this in the other CL for tap suppression?

[Donn Denman, 2016-06-27 20:43:01]

Thanks for taking a look Theresa.  Pedro, want to take a look or should we just
move T as the main reviewer?

https://chromiumcodereview.appspot.com/2099753003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java
(right):

https://chromiumcodereview.appspot.com/2099753003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java:545:
return getTapCount() -
mPreferenceManager.getContextualSearchTapQuickAnswerCount()
On 2016/06/27 18:46:40, twellington_google.com wrote:
> Do we need to do something like this in the other CL for tap suppression?

Yes, thanks for reminding me.  We can land this and then compensate in that CL
too.

[pedro (no code reviews), 2016-06-27 21:11:11]

lgtm

https://codereview.chromium.org/2099753003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java
(right):

https://codereview.chromium.org/2099753003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java:545:
return getTapCount() -
mPreferenceManager.getContextualSearchTapQuickAnswerCount()
Put an explanation here to clarify why we are subtracting the quick answer taps.

[Donn Denman, 2016-06-27 21:18:07]

Theresa, PTAL at least for owners of ChromePreferenceManager.  Thanks!

[Donn Denman, 2016-06-27 21:21:01]

donnd@chromium.org changed reviewers:
+ tedchoc@chromium.org
- twellington@google.com

[Donn Denman, 2016-06-27 21:21:02]

Ted, PTAL at ChromePreferenceManager for OWNERS.

Theresa, looks like you're not on that OWNERS list, sorry for any confusion.

[Ted C, 2016-06-27 23:14:32]

lgtm

[Donn Denman, 2016-06-27 23:15:28]

The CQ bit was checked by donnd@chromium.org

[Donn Denman, 2016-06-27 23:15:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/2099753003/#ps20001
(title: "Just added a comment.")

[commit-bot: I haz the power, 2016-06-27 23:16:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 00:49:29]

Description was changed from

==========
[TTS] Update Tap counters to compensate for Quick Answers.

When a Tap causes a Quick Answer that shows a caption with doesAnswer,
the user has no real need to open the panel.

This change counts Answers since the last open and uses them to compensate
for Taps without any panel open so we don't stop resolving and preloading
(which would cause subsequent Quick Answers to not appear automatically).

BUG=622160,609924
==========

to

==========
[TTS] Update Tap counters to compensate for Quick Answers.

When a Tap causes a Quick Answer that shows a caption with doesAnswer,
the user has no real need to open the panel.

This change counts Answers since the last open and uses them to compensate
for Taps without any panel open so we don't stop resolving and preloading
(which would cause subsequent Quick Answers to not appear automatically).

BUG=622160,609924
==========

[commit-bot: I haz the power, 2016-06-28 00:49:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-28 00:52:23]

Description was changed from

==========
[TTS] Update Tap counters to compensate for Quick Answers.

When a Tap causes a Quick Answer that shows a caption with doesAnswer,
the user has no real need to open the panel.

This change counts Answers since the last open and uses them to compensate
for Taps without any panel open so we don't stop resolving and preloading
(which would cause subsequent Quick Answers to not appear automatically).

BUG=622160,609924
==========

to

==========
[TTS] Update Tap counters to compensate for Quick Answers.

When a Tap causes a Quick Answer that shows a caption with doesAnswer,
the user has no real need to open the panel.

This change counts Answers since the last open and uses them to compensate
for Taps without any panel open so we don't stop resolving and preloading
(which would cause subsequent Quick Answers to not appear automatically).

BUG=622160,609924

Committed: https://crrev.com/210d15f8993fa63424af4cfefd9678c4995e647f
Cr-Commit-Position: refs/heads/master@{#402351}
==========

[commit-bot: I haz the power, 2016-06-28 00:52:24]

Patchset 2 (id:??) landed as
https://crrev.com/210d15f8993fa63424af4cfefd9678c4995e647f
Cr-Commit-Position: refs/heads/master@{#402351}