Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2099753002: Make bucket names explicit in cq.cfg. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG=chromium:617627 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/631e22d24a37d9c1b7092a5d3a15d27e2769d6bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
tandrii(chromium)
PTAL
4 years, 6 months ago (2016-06-24 18:10:23 UTC) #3
Sergiy Byelozyorov
lgtm
4 years, 6 months ago (2016-06-24 18:17:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099753002/1
4 years, 6 months ago (2016-06-24 18:19:22 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-24 18:19:24 UTC) #8
tandrii(chromium)
Added two NACL committers for rs-lgtm, please.
4 years, 5 months ago (2016-06-27 14:50:28 UTC) #10
pasko
rs lgtm (though I do not work on nacl any more)
4 years, 5 months ago (2016-06-27 14:55:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099753002/1
4 years, 5 months ago (2016-06-27 14:57:25 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 14:58:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/631e22d24...

Powered by Google App Engine
This is Rietveld 408576698