Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2099693002: Revert of Remove Android SampleApp (Closed)

Created:
4 years, 6 months ago by rmistry
Modified:
4 years, 5 months ago
Reviewers:
djsollen, liyuqian
CC:
reviews_skia.org, Brian Osman
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Remove Android SampleApp (patchset #5 id:80001 of https://codereview.chromium.org/2096683002/ ) Reason for revert: Testing to see if this CL caused the failures in Build-Mac-Clang-Arm7-Debug-Android Original issue's description: > Remove Android SampleApp > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096683002 > > Committed: https://skia.googlesource.com/skia/+/41bb5b40e71411ee39538399ea125986ec760a90 TBR=djsollen@google.com,liyuqian@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/7bde5659d354b4ef227c487a4e9fa8de12573c31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1564 lines, -6 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
M gyp/everything.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/most.gyp View 1 chunk +1 line, -4 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A include/views/SkOSWindow_Android.h View 1 chunk +53 lines, -0 lines 0 comments Download
M include/views/SkWindow.h View 1 chunk +1 line, -1 line 0 comments Download
A platform_tools/android/apps/sample_app/build.gradle View 1 chunk +30 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/AndroidManifest.xml View 1 chunk +22 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java View 1 chunk +251 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleRenderer.java View 1 chunk +113 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java View 1 chunk +310 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/jni/AndroidKeyToSkKey.h View 1 chunk +34 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.h View 1 chunk +164 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp View 1 chunk +356 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_next.png View Binary file 0 comments Download
A platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_prev.png View Binary file 0 comments Download
A platform_tools/android/apps/sample_app/src/main/res/layout/layout.xml View 1 chunk +17 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/res/menu/action_bar.xml View 1 chunk +75 lines, -0 lines 0 comments Download
A platform_tools/android/apps/sample_app/src/main/res/values/strings.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M platform_tools/android/apps/settings.gradle View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 chunk +32 lines, -0 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rmistry
Created Revert of Remove Android SampleApp
4 years, 6 months ago (2016-06-24 12:01:01 UTC) #1
rmistry
Looks like the trybot run with this revert succeeded: https://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-Android-Trybot/builds/10 I am going to submit ...
4 years, 6 months ago (2016-06-24 12:23:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2099693002/1
4 years, 6 months ago (2016-06-24 12:24:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7bde5659d354b4ef227c487a4e9fa8de12573c31
4 years, 6 months ago (2016-06-24 12:24:20 UTC) #6
rmistry
On 2016/06/24 12:24:20, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 5 months ago (2016-06-27 12:53:03 UTC) #7
rmistry
4 years, 5 months ago (2016-06-27 16:19:46 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2104453002/ by rmistry@google.com.

The reason for reverting is: Creating reland to test trybot runs...

Powered by Google App Engine
This is Rietveld 408576698