net/log/net_log_event_type_list.h - Issue 2099673003: Delete TLS version fallback code in net/http.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/net_log_event_type_list.h

Issue 2099673003: Delete TLS version fallback code in net/http. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback-die-die-die-2

Patch Set: fix build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/log/net_log_event_type_list.h

diff --git a/net/log/net_log_event_type_list.h b/net/log/net_log_event_type_list.h

index 24d0ad4a113983a14d99e607b4d9a73bb9571042..4b9bdf9174ec7e5f871cb211794cbcd481fcccdf 100644

--- a/net/log/net_log_event_type_list.h

+++ b/net/log/net_log_event_type_list.h

@@ -532,17 +532,6 @@ EVENT_TYPE(SSL_HANDSHAKE_ERROR)

EVENT_TYPE(SSL_READ_ERROR)

EVENT_TYPE(SSL_WRITE_ERROR)

-// An SSL connection needs to be retried with a lower protocol version because

-// the server may be intolerant of the protocol version we offered.

-// The following parameters are attached to the event:

-// {

-// "host_and_port": <String encoding the host and port>,

-// "net_error": <Net integer error code>,

-// "version_before": <SSL version before the fallback>,

-// "version_after": <SSL version after the fallback>,

-// }

-EVENT_TYPE(SSL_VERSION_FALLBACK)

Ryan Sleevi 2016/06/24 18:51:26 Do we need to preserve these IDs in any meaningful

eroman 2016/06/24 18:56:07 No, there is no need to preserve IDs. Legacy log f

// An SSL connection needs to be retried with more cipher suites because the

// server may require a deprecated cipher suite. The following parameters are

// attached to the event:

« no previous file with comments | « net/http/http_network_transaction_ssl_unittest.cc ('k') | net/socket/client_socket_pool_manager.cc » ('j') | no next file with comments »