Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2099643002: Make Editor::replaceSelectionWithFragment() to update layout tree explicitly (Closed)

Created:
4 years, 6 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Editor::replaceSelectionWithFragment() to update layout tree explicitly This patch makes |Editor::replaceSelectionWithFragment()| to update layout tree explicitly for preparation of crrev.com/2089993003, Get rid of |EUpdateStyle| parameter from |isEditablePosition()|. BUG=623005 TEST=n/a; no behavior changes Committed: https://crrev.com/20c47d5dabdf4e4170d53404bb93f4ca39677a46 Cr-Commit-Position: refs/heads/master@{#402099}

Patch Set 1 : 2016-06-24T17:43:28 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 6 months ago (2016-06-24 09:12:38 UTC) #3
yoichio
lgtm
4 years, 6 months ago (2016-06-24 09:48:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099643002/1
4 years, 5 months ago (2016-06-27 01:42:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 02:53:30 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 02:56:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20c47d5dabdf4e4170d53404bb93f4ca39677a46
Cr-Commit-Position: refs/heads/master@{#402099}

Powered by Google App Engine
This is Rietveld 408576698