Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 209963002: gclient: Fix nested checkout bug when validating .gclient (Closed)

Created:
6 years, 9 months ago by borenet
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Henrik Grunell, tommi (sloooow) - chröme
Visibility:
Public.

Description

gclient: Fix nested checkout bug when validating .gclient BUG=355492 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=258989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M gclient_scm.py View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
borenet
6 years, 9 months ago (2014-03-24 13:35:38 UTC) #1
tommi (sloooow) - chröme
lgtm! thanks for the quick fix.
6 years, 9 months ago (2014-03-24 15:45:48 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 9 months ago (2014-03-24 18:26:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/209963002/1
6 years, 9 months ago (2014-03-24 18:26:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:28:44 UTC) #5
commit-bot: I haz the power
Presubmit check for 209963002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 9 months ago (2014-03-24 18:28:44 UTC) #6
iannucci
lgtm
6 years, 9 months ago (2014-03-24 19:02:16 UTC) #7
borenet
The CQ bit was checked by borenet@google.com
6 years, 9 months ago (2014-03-24 19:02:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/209963002/1
6 years, 9 months ago (2014-03-24 19:03:06 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 19:04:47 UTC) #10
Message was sent while issue was closed.
Change committed as 258989

Powered by Google App Engine
This is Rietveld 408576698