Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2099623002: Add a content_browsertest for LoadDataWithBaseURL + Back. (Closed)

Created:
4 years, 6 months ago by Charlie Reis
Modified:
4 years, 6 months ago
Reviewers:
boliu
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, mnaganov (inactive), site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a content_browsertest for LoadDataWithBaseURL + Back. The current navigation logic has a bug that loads the history URL but lies and claims the data URL is committed. This bug is fixed in the new navigation logic with subframe FrameNavigationEntries. This CL adds a test showing these two expectations, mimicing org.chromium.android_webview.test.LoadDataWithBaseUrlTest's It's easier to switch to the new navigation logic than fix the bug in the old logic. BUG=612196 TEST=Test passes by default and in --site-per-process. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/fa6742e4236b8efa17c8eb60f23f566f64b1c500 Cr-Commit-Position: refs/heads/master@{#401912}

Patch Set 1 : Initial patch #

Patch Set 2 : Fix Windows compile #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 1 chunk +63 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
Charlie Reis
Bo, can you take a look? This ports LoadDataWithBaseUrlTest#testHistoryUrlNavigation to a content_browsertest and updates the ...
4 years, 6 months ago (2016-06-24 17:02:12 UTC) #4
boliu
lgtm
4 years, 6 months ago (2016-06-24 17:34:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099623002/40001
4 years, 6 months ago (2016-06-24 17:44:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-24 18:36:49 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 18:38:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa6742e4236b8efa17c8eb60f23f566f64b1c500
Cr-Commit-Position: refs/heads/master@{#401912}

Powered by Google App Engine
This is Rietveld 408576698