Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2099573002: Revert of Disable SiteInstanceTest.* under Dr. Memory. (Closed)

Created:
4 years, 6 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable SiteInstanceTest.* under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2090393002/ ) Reason for revert: Reverted https://codereview.chromium.org/2045363002/. Original issue's description: > Disable SiteInstanceTest.* under Dr. Memory. > > They are failing. > > BUG=622793 > TBR=nick@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/8e6872f8f8b89bb49bda37577c7e0800ebee2488 TBR=nick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622793 Committed: https://crrev.com/31189d3191c823005b7d09f980953195ccf66765 Cr-Commit-Position: refs/heads/master@{#401772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Reilly Grant (use Gerrit)
Created Revert of Disable SiteInstanceTest.* under Dr. Memory.
4 years, 6 months ago (2016-06-24 01:25:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2099573002/1
4 years, 6 months ago (2016-06-24 01:26:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 01:27:06 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 01:30:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31189d3191c823005b7d09f980953195ccf66765
Cr-Commit-Position: refs/heads/master@{#401772}

Powered by Google App Engine
This is Rietveld 408576698