Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2099563003: fix const reference declaration (Closed)

Created:
4 years, 6 months ago by Pete Williamson
Modified:
4 years, 6 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix const reference declaration We should have declared the type as "const MyType&" instead of "MyType const &". BUG=610521 Committed: https://crrev.com/44953f5748c4a48c619ac10770425c76346132c7 Cr-Commit-Position: refs/heads/master@{#401998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/offline_pages/background/request_coordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Pete Williamson
4 years, 6 months ago (2016-06-24 21:30:00 UTC) #2
fgorski
LGTM
4 years, 6 months ago (2016-06-24 21:59:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099563003/1
4 years, 6 months ago (2016-06-24 22:03:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 22:46:10 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 22:49:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44953f5748c4a48c619ac10770425c76346132c7
Cr-Commit-Position: refs/heads/master@{#401998}

Powered by Google App Engine
This is Rietveld 408576698