WebUI: DisallowJavascript only on Refresh and non-same-page navigations

content/public/browser/web_ui_message_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
@@ skipping 24 matching lines @@
   WebUIMessageHandler() : javascript_allowed_(false), web_ui_(nullptr) {}
   virtual ~WebUIMessageHandler() {}
 
   // Call this when a page should not receive JavaScript messages.
   void DisallowJavascript();
 
   // Called from tests to toggle JavaScript to catch bugs. If AllowJavascript()
   // is needed from production code, just publicize AllowJavascript() instead.
   void AllowJavascriptForTesting();
 
+  bool IsJavascriptAllowed() const;
+
  protected:
   FRIEND_TEST_ALL_PREFIXES(WebUIMessageHandlerTest, ExtractIntegerValue);
   FRIEND_TEST_ALL_PREFIXES(WebUIMessageHandlerTest, ExtractDoubleValue);
   FRIEND_TEST_ALL_PREFIXES(WebUIMessageHandlerTest, ExtractStringValue);
 
   // Subclasses must call this once the page is ready for JavaScript calls
   // from this handler.
   void AllowJavascript();
 
-  bool IsJavascriptAllowed() const;
-
   // Helper methods:
 
   // Extract an integer value from a list Value.
   static bool ExtractIntegerValue(const base::ListValue* value, int* out_int);
 
   // Extract a floating point (double) value from a list Value.
   static bool ExtractDoubleValue(const base::ListValue* value,
                                  double* out_value);
 
   // Extract a string value from a list Value.
@@ skipping 48 matching lines @@
 
   // Sets the attached WebUI - exposed to subclasses for testing purposes.
   void set_web_ui(WebUI* web_ui) { web_ui_ = web_ui; }
 
  private:
   // Provide external classes access to web_ui(), set_web_ui(), and
   // RenderViewReused.
   friend class WebUIImpl;
   friend class ::WebUIBrowserTest;
 
-  // Called when a RenderView is reused to display a page (i.e. reload).
-  void RenderViewReused();
-
   // TODO(dbeam): disallow JavaScript when a renderer process crashes.
   // http://crbug.com/610450
 
   // True if the page is for JavaScript calls from this handler.
   bool javascript_allowed_;
 
   WebUI* web_ui_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_