third_party/WebKit/LayoutTests/fast/block/float/float-reparent-during-detach-crash.html - Issue 2099523002: Avoid dereferencing layoutObject during FloatingObject::unsafeClone

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/float/float-reparent-during-detach-crash.html

Issue 2099523002: Avoid dereferencing layoutObject during FloatingObject::unsafeClone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: none Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/block/float/float-reparent-during-detach-crash-expected.txt » ('j') | third_party/WebKit/Source/core/layout/FloatingObjects.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype HTML>

	2 Passes if it does not crash.
	wkorman 2016/06/24 18:10:35 Does this crash without the change, in a non-ASAN Does this crash without the change, in a non-ASAN build? Or is this test just for validating fix with ASAN? It doesn't seem to crash with current ToT or dev build. chrishtr 2016/07/01 15:43:39 Just crashes in ASAN. But there are ASAN bots that Show quoted text On 2016/06/24 at 18:10:35, wkorman wrote: > Does this crash without the change, in a non-ASAN build? Or is this test just for validating fix with ASAN? It doesn't seem to crash with current ToT or dev build. Just crashes in ASAN. But there are ASAN bots that run on all layout tests.
	3 <ruby>

	4 test

	5 <rt>

	6 <rtc>

	7 <a style="display:list-item">

	8 <input style="float:right"></input>

	9 </rtc>

	10 </a>

	11 </rt>

	12 </ruby>

	13 <script>

	14 if (window.testRunner)

	15 window.testRunner.dumpAsText();

	16 onload = function() {

	17 var mySelection=window.getSelection();

	18 document.execCommand("SelectAll");

	19 mySelection.deleteFromDocument();

	20 }

	21 </script>

OLD	NEW