mus: Use the new drag API to implement tab dragging in chrome.

ash/mus/window_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/mus/window_manager.h"
 
 #include <stdint.h>
 
 #include <utility>
 
 #include "ash/common/shell_window_ids.h"
 #include "ash/mus/bridge/wm_lookup_mus.h"
 #include "ash/mus/bridge/wm_shell_mus.h"
 #include "ash/mus/bridge/wm_window_mus.h"
+#include "ash/mus/frame/move_event_handler.h"
 #include "ash/mus/non_client_frame_controller.h"
 #include "ash/mus/property_util.h"
 #include "ash/mus/root_window_controller.h"
 #include "ash/mus/root_windows_observer.h"
 #include "ash/mus/shadow_controller.h"
 #include "ash/mus/window_manager_application.h"
 #include "ash/public/interfaces/container.mojom.h"
 #include "components/mus/common/event_matcher_util.h"
 #include "components/mus/common/types.h"
 #include "components/mus/public/cpp/property_type_converters.h"
 #include "components/mus/public/cpp/window.h"
 #include "components/mus/public/cpp/window_property.h"
 #include "components/mus/public/cpp/window_tree_client.h"
 #include "components/mus/public/interfaces/mus_constants.mojom.h"
 #include "components/mus/public/interfaces/window_manager.mojom.h"
+#include "ui/base/hit_test.h"
 #include "ui/events/mojo/event.mojom.h"
 #include "ui/views/mus/screen_mus.h"
 
 namespace ash {
 namespace mus {
 
 const uint32_t kWindowSwitchAccelerator = 1;
 
 void AssertTrue(bool success) {
   DCHECK(success);
@@ skipping 182 matching lines @@
     bool janky) {
   for (auto window : client_windows)
     SetWindowIsJanky(window, janky);
 }
 
 void WindowManager::OnWmNewDisplay(::mus::Window* window,
                                    const display::Display& display) {
   CreateRootWindowController(window, display);
 }
 
+void WindowManager::OnWmPerformMoveLoop(
+    ::mus::Window* window,
+    ::mus::mojom::MoveLoopSource source,
+    const gfx::Point& cursor_location,
+    const base::Callback<void(bool)>& on_done) {
+  WmWindowMus* child_window = WmWindowMus::Get(window);

[sky, 2016/06/30 00:18:31]

DCHECK there isn't a drag in progress?

+  MoveEventHandler* handler = MoveEventHandler::GetForWindow(child_window);

[sky, 2016/06/30 00:18:31]

Fail if there is no handler. This would happen if the wm is told to drag a
window it hasn't installed a frame for, which is possible.

+  aura::client::WindowMoveSource aura_source =
+      source == ::mus::mojom::MoveLoopSource::MOUSE
+          ? aura::client::WINDOW_MOVE_SOURCE_MOUSE
+          : aura::client::WINDOW_MOVE_SOURCE_TOUCH;
+  handler->AttemptToStartDrag(cursor_location, HTCAPTION, aura_source, on_done);
+}
+
+void WindowManager::OnWmCancelMoveLoop(::mus::Window* window) {
+  WmWindowMus* child_window = WmWindowMus::Get(window);
+  MoveEventHandler* handler = MoveEventHandler::GetForWindow(child_window);

[sky, 2016/06/30 00:18:31]

Same comment here about checking handler.

+  handler->RevertDrag();

[sky, 2016/06/30 00:18:31]

What happens if RevertDrag is called and there isn't a drag in progress? I want
to make sure we don't crash.

[Elliot Glaysher, 2016/06/30 19:48:25]

It doesn't. WmToplevelWindowEventHandler::CompleteDrag() just returns false if
there isn't a drag in progress.

+}
+
 void WindowManager::OnAccelerator(uint32_t id, const ui::Event& event) {
   switch (id) {
     case kWindowSwitchAccelerator:
       window_manager_client()->ActivateNextWindow();
       break;
     default:
       window_manager_app_->OnAccelerator(id, event);
       break;
   }
 }
 
-void WindowManager::OnWmPerformMoveLoop(
-    ::mus::Window* window,
-    ::mus::mojom::MoveLoopSource source,
-    const gfx::Point& cursor_location,
-    const base::Callback<void(bool)>& on_done) {
-  NOTIMPLEMENTED();
-}
-
-void WindowManager::OnWmCancelMoveLoop(::mus::Window* window) {
-  NOTIMPLEMENTED();
-}
-
 }  // namespace mus
 }  // namespace ash