Migrate simple ash Shell metrics users.

Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org,sky@chromium.org

Committed: https://crrev.com/76014a371acaa910a826d268cf739d722763c96b
Cr-Commit-Position: refs/heads/master@{#401750}

[msw, 2016-06-23 20:09:56]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 20:10:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2099443002/20001

[msw, 2016-06-23 20:15:23]

Description was changed from

==========
Migrate simple ash Shell metrics users.

BUG=619636
==========

to

==========
Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org
==========

[msw, 2016-06-23 20:15:23]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-06-23 20:15:40]

Hey James, please take a look; thanks!

[James Cook, 2016-06-23 20:23:13]

LGTM

https://codereview.chromium.org/2099443002/diff/20001/ash/frame/caption_butto...
File ash/frame/caption_buttons/frame_caption_button_container_view.cc (right):

https://codereview.chromium.org/2099443002/diff/20001/ash/frame/caption_butto...
ash/frame/caption_buttons/frame_caption_button_container_view.cc:323:
UserMetricsAction action = UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_MINIMIZE;
thanks for cleaning up the namespaces

https://codereview.chromium.org/2099443002/diff/20001/ash/system/chromeos/blu...
File ash/system/chromeos/bluetooth/tray_bluetooth.cc (right):

https://codereview.chromium.org/2099443002/diff/20001/ash/system/chromeos/blu...
ash/system/chromeos/bluetooth/tray_bluetooth.cc:295: if (login_ ==
LoginStatus::NOT_LOGGED_IN || login_ == LoginStatus::LOCKED ||
ugh, we really need a shared piece of code for this. But that's a problem for
another CL, I guess.

[commit-bot: I haz the power, 2016-06-23 20:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 20:40:50]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[msw, 2016-06-23 21:08:09]

Description was changed from

==========
Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org
==========

to

==========
Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org,sky@chromium.org
==========

[msw, 2016-06-23 21:08:09]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-06-23 21:08:49]

Scott, please take a look for chrome/* OWNERS; thanks!

https://codereview.chromium.org/2099443002/diff/20001/ash/frame/caption_butto...
File ash/frame/caption_buttons/frame_caption_button_container_view.cc (right):

https://codereview.chromium.org/2099443002/diff/20001/ash/frame/caption_butto...
ash/frame/caption_buttons/frame_caption_button_container_view.cc:323:
UserMetricsAction action = UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_MINIMIZE;
On 2016/06/23 20:23:12, James Cook wrote:
> thanks for cleaning up the namespaces

Acknowledged.

https://codereview.chromium.org/2099443002/diff/20001/ash/system/chromeos/blu...
File ash/system/chromeos/bluetooth/tray_bluetooth.cc (right):

https://codereview.chromium.org/2099443002/diff/20001/ash/system/chromeos/blu...
ash/system/chromeos/bluetooth/tray_bluetooth.cc:295: if (login_ ==
LoginStatus::NOT_LOGGED_IN || login_ == LoginStatus::LOCKED ||
On 2016/06/23 20:23:12, James Cook wrote:
> ugh, we really need a shared piece of code for this. But that's a problem for
> another CL, I guess.

Acknowledged.

[msw, 2016-06-23 21:08:59]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 21:09:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2099443002/40001

[commit-bot: I haz the power, 2016-06-23 21:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 21:57:38]

Dry run: This issue passed the CQ dry run.

[sky, 2016-06-23 22:42:54]

LGTM

[msw, 2016-06-23 23:07:20]

The CQ bit was checked by msw@chromium.org

[msw, 2016-06-23 23:07:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2099443002/#ps40001
(title: "Fix win compile error.")

[commit-bot: I haz the power, 2016-06-23 23:08:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2099443002/40001

[commit-bot: I haz the power, 2016-06-23 23:15:12]

Description was changed from

==========
Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org,sky@chromium.org
==========

to

==========
Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org,sky@chromium.org
==========

[commit-bot: I haz the power, 2016-06-23 23:15:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-23 23:17:15]

Description was changed from

==========
Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org,sky@chromium.org
==========

to

==========
Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org,sky@chromium.org

Committed: https://crrev.com/76014a371acaa910a826d268cf739d722763c96b
Cr-Commit-Position: refs/heads/master@{#401750}
==========

[commit-bot: I haz the power, 2016-06-23 23:17:17]

Patchset 3 (id:??) landed as
https://crrev.com/76014a371acaa910a826d268cf739d722763c96b
Cr-Commit-Position: refs/heads/master@{#401750}