Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2099353002: Revert of Delete the chromium_gpu_builder and chromium_gpu_debug_builder targets. (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
CC:
chromium-reviews, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delete the chromium_gpu_builder and chromium_gpu_debug_builder targets. (patchset #1 id:1 of https://codereview.chromium.org/2091153003/ ) Reason for revert: khronos_glcts_test is in fact used on Chrome OS. It is referenced in the ebuild. See crbug.com/623448 for the build failures. Original issue's description: > Delete the chromium_gpu_builder and chromium_gpu_debug_builder targets. > > These are no longer referenced. > > BUG=299367 > > Committed: https://crrev.com/9e447b2a288eba754dfc477d359840286f69e6a5 > Cr-Commit-Position: refs/heads/master@{#401788} TBR=dpranke@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=299367 Committed: https://crrev.com/233d288d39b1f5bafed1658859a7c326898dc1a9 Cr-Commit-Position: refs/heads/master@{#402224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
stevenjb
Created Revert of Delete the chromium_gpu_builder and chromium_gpu_debug_builder targets.
4 years, 5 months ago (2016-06-27 16:51:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099353002/1
4 years, 5 months ago (2016-06-27 16:52:12 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-06-27 17:24:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 18:00:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/233d288d39b1f5bafed1658859a7c326898dc1a9 Cr-Commit-Position: refs/heads/master@{#402224}
4 years, 5 months ago (2016-06-27 18:03:13 UTC) #8
Ken Russell (switch to Gerrit)
4 years, 5 months ago (2016-06-27 18:10:09 UTC) #9
Message was sent while issue was closed.
lgtm, sorry for the breakage

Powered by Google App Engine
This is Rietveld 408576698