Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2099343002: Address ASAN fuzzer complaint (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Address ASAN fuzzer complaint This addresses a class of fuzzer failure where the paint index has been made invalid but the calling code doesn't handle a null pointer return. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2099343002 Committed: https://skia.googlesource.com/skia/+/5354e4a0c2b629b5336fbd3743944fe059514141

Patch Set 1 #

Patch Set 2 : Address ASAN fuzzer complaint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -38 lines) Patch
M src/core/SkPicturePlayback.cpp View 8 chunks +68 lines, -38 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 5 months ago (2016-06-27 16:52:23 UTC) #4
bsalomon
lgtm
4 years, 5 months ago (2016-06-27 17:09:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099343002/20001
4 years, 5 months ago (2016-06-27 18:19:11 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 18:52:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099343002/20001
4 years, 5 months ago (2016-06-27 19:04:45 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 19:05:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5354e4a0c2b629b5336fbd3743944fe059514141

Powered by Google App Engine
This is Rietveld 408576698