Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2099333002: Ensure ccompute buildbot checkouts remain managed (Closed)

Created:
4 years, 5 months ago by agable
Modified:
4 years, 5 months ago
Reviewers:
hinoka
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M infra/tools/bot_setup/start/chrome.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
agable
4 years, 5 months ago (2016-06-27 16:41:36 UTC) #1
hinoka
lgtm once this lands you'll have to bump the "ccompute" pin on cipd.
4 years, 5 months ago (2016-06-27 17:44:20 UTC) #2
Vadim Sh.
On 2016/06/27 17:44:20, hinoka wrote: > lgtm > > once this lands you'll have to ...
4 years, 5 months ago (2016-06-27 17:45:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099333002/1
4 years, 5 months ago (2016-06-28 17:32:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/55f747806e7882747b4dbb19c54b9b73fbdf58a4
4 years, 5 months ago (2016-06-28 17:48:48 UTC) #7
agable
On 2016/06/27 at 17:45:36, vadimsh wrote: > On 2016/06/27 17:44:20, hinoka wrote: > > lgtm ...
4 years, 5 months ago (2016-06-28 18:21:54 UTC) #8
Vadim Sh.
On 2016/06/28 18:21:54, agable wrote: > On 2016/06/27 at 17:45:36, vadimsh wrote: > > On ...
4 years, 5 months ago (2016-06-28 18:27:42 UTC) #9
agable
4 years, 5 months ago (2016-06-28 18:34:01 UTC) #10
Message was sent while issue was closed. 
On 2016/06/28 at 18:27:42, vadimsh wrote:
> On 2016/06/28 18:21:54, agable wrote:
> > On 2016/06/27 at 17:45:36, vadimsh wrote:
> > > On 2016/06/27 17:44:20, hinoka wrote:
> > > > lgtm
> > > > 
> > > > once this lands you'll have to bump the "ccompute" pin on cipd.
> > > 
> > > (Step 7 here
> >
https://chrome-internal.googlesource.com/infra/infra_internal/+/master/doc/in...)
> > 
> > Followed those instructions; won't let me update the version because the
> > continuous waterfall no longer uploads packages for mac10.6-10.8:
> > ± ./cipd set-ref infra/infra_python/ \
> >     -ref=ccompute \
> >     -version=git_revision:55f747806e7882747b4dbb19c54b9b73fbdf58a4
> > Packages:
> >  
> >
infra/infra_python/linux-386-ubuntu12_04:fbb1cb92922f9dad6d369a54e77a8c3ce719ed8b
> >  
> >
infra/infra_python/linux-386-ubuntu14_04:32e3344bb20d88c58593790fb649578fa82f7601
> >  
> >
infra/infra_python/linux-amd64-ubuntu12_04:6179eb0c72046a84afc1af29fd1bf8133aea4b21
> >  
> >
infra/infra_python/linux-amd64-ubuntu14_04:34d6488d2d75d2859f78b552d39cd70c2e3026e3
> >  
> >
infra/infra_python/linux-amd64-ubuntu15_10:830d55da6248045f67eccabbb45c2e723f37c8b2
> >  
infra/infra_python/mac-amd64-mac10_10:aff5ff8307441c7bc1ce37db5aada4cfc396a176
> >  
infra/infra_python/mac-amd64-mac10_11:ebd155050156d365d898c141a6cc273b7a539a8e
> >  
infra/infra_python/mac-amd64-mac10_9:8dce9aec79d45f67da2ab0a370cf8377a8a9913c
> >  
infra/infra_python/windows-386-win6_1:ee3cd37e95c3d0ac49092c30fde83f01c05ed118
> >  
> >
infra/infra_python/windows-amd64-win6_1:c566f8d94919ef386ef893928309a3a6ce5cb768
> > Errors:
> >   infra/infra_python/mac-amd64-mac10_6: package
> > "infra/infra_python/mac-amd64-mac10_6" doesn't have instance with version
> > "git_revision:55f747806e7882747b4dbb19c54b9b73fbdf58a4".
> >   infra/infra_python/mac-amd64-mac10_7: package
> > "infra/infra_python/mac-amd64-mac10_7" doesn't have instance with version
> > "git_revision:55f747806e7882747b4dbb19c54b9b73fbdf58a4".
> >   infra/infra_python/mac-amd64-mac10_8: package
> > "infra/infra_python/mac-amd64-mac10_8" doesn't have instance with version
> > "git_revision:55f747806e7882747b4dbb19c54b9b73fbdf58a4".
> > No packages.
> > Error: can't find "git_revision:55f747806e7882747b4dbb19c54b9b73fbdf58a4"
> > version in all packages, aborting.
> 
> Eh. Ok.
> 
> One option is to delete mac packages, but it seems wrong (loosing history)...
I'll teach CIPD backend to hide them from the listing instead.
> 
> Meanwhile, please use more verbose:
> 
> ./cipd set-ref infra/infra_python/linux-amd64-ubuntu12_04 \
>      -ref=ccompute \
>      -version=git_revision:55f747806e7882747b4dbb19c54b9b73fbdf58a4
> ./cipd set-ref infra/infra_python/linux-amd64-ubuntu14_04 \
>      -ref=ccompute \
>      -version=git_revision:55f747806e7882747b4dbb19c54b9b73fbdf58a4
> ./cipd set-ref infra/infra_python/linux-amd64-ubuntu15_10 \
>      -ref=ccompute \
>      -version=git_revision:55f747806e7882747b4dbb19c54b9b73fbdf58a4
> ...

Thanks, I've done all the packages individually now.

Powered by Google App Engine
This is Rietveld 408576698