build/android/pylib/local/device/local_device_instrumentation_test_run.py - Issue 2099323002: [Android] Prepare the test runner for @RetryOnFailure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2099323002: [Android] Prepare the test runner for @RetryOnFailure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/test/android/javatests/src/org/chromium/base/test/util/RetryOnFailure.java ('k') | build/android/pylib/local/device/local_device_test_run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py

diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

index d5426bc3e66d52eddf8b6e595e102d5aa0550782..ee6f7a45c2b8e4fde7419885ea3d7778e9737365 100644

--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -331,6 +331,17 @@ class LocalDeviceInstrumentationTestRun(

return results

#override

+ def _ShouldRetry(self, test):

+ if 'RetryOnFailure' in test.get('annotations', {}):

+ return True

+ # TODO(jbudorick): Remove this log message and switch the return value to

+ # False after tests have been annotated with @RetryOnFailure.

+ # See crbug.com/619055 for more details.

+ logging.warning('Default retries are being phased out. crbug.com/619055')

+ return True

+ #override

def _ShouldShard(self):

return True