[Android] Prepare the test runner for @RetryOnFailure.

[Android] Prepare the test runner for @RetryOnFailure.

BUG=619055
Committed: https://crrev.com/ec256fa7e036723529be5dbe631bbb9045b0ed97
Cr-Commit-Position: refs/heads/master@{#404774}

[jbudorick, 2016-06-27 15:43:55]

jbudorick@chromium.org changed reviewers:
+ mikecase@chromium.org, rnephew@chromium.org

[jbudorick, 2016-07-01 17:31:06]

ping

[mikecase (-- gone --), 2016-07-01 19:00:37]

lgtm with 1 question (its about code you didnt change though)

https://codereview.chromium.org/2099323002/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_test_run.py (right):

https://codereview.chromium.org/2099323002/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_test_run.py:175: if
name.endswith('*'):
I dont think I understand this. I get that a * can be in the test filter, but
why would a * appear in the all_test_results list. Shouldnt that be a list of
the tests that actually ran?

[jbudorick, 2016-07-11 16:32:52]

https://codereview.chromium.org/2099323002/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_test_run.py (right):

https://codereview.chromium.org/2099323002/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_test_run.py:175: if
name.endswith('*'):
On 2016/07/01 19:00:37, mikecase wrote:
> I dont think I understand this. I get that a * can be in the test filter, but
> why would a * appear in the all_test_results list. Shouldnt that be a list of
> the tests that actually ran?

Yeah, this is a bit complicated because of an optimization here:
https://chromium.googlesource.com/chromium/src/+/master/build/android/pylib/l...

* wouldn't appear in all_test_results, but test_failed isn't being called on the
contents of all_test_results. It's being called on the names of all the tests in
tests, i.e., whatever is returned from _GetTests. Because of that optimization,
that can be something that ends with *.

I'm not entirely thrilled about the existence of that optimization given the
complications it introduces, but it does make gtest execution a few seconds
faster for devs running, e.g., -f FooTest.*

[jbudorick, 2016-07-11 16:34:48]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-07-11 16:34:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2099323002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-11 16:35:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 18:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 18:21:00]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbudorick, 2016-07-12 01:22:01]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:22:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 03:16:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-12 03:17:04]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-12 03:20:09]

Description was changed from

==========
[Android] Prepare the test runner for @RetryOnFailure.

BUG=619055
==========

to

==========
[Android] Prepare the test runner for @RetryOnFailure.

BUG=619055

Committed: https://crrev.com/ec256fa7e036723529be5dbe631bbb9045b0ed97
Cr-Commit-Position: refs/heads/master@{#404774}
==========

[commit-bot: I haz the power, 2016-07-12 03:20:10]

Patchset 2 (id:??) landed as
https://crrev.com/ec256fa7e036723529be5dbe631bbb9045b0ed97
Cr-Commit-Position: refs/heads/master@{#404774}