Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2099293002: Subzero: Make -translate-only work with nonzero -threads=<N>. (Closed)

Created:
4 years, 5 months ago by Jim Stichnoth
Modified:
4 years, 5 months ago
Reviewers:
Eric Holk, Karl, John, manasijm
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Make -translate-only work with nonzero -threads=<N>. When we skip translating an item due to the -translate-only option, we still need to add a dummy item to the work queue with the proper sequence number, otherwise the emitter thread waits endlessly for the next sequence number and never emits the rest of the items. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5f55d40577b013ee9ab9d8c838650e9f35cd0d1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/IceGlobalContext.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 5 months ago (2016-06-27 14:07:11 UTC) #3
John
lgtm
4 years, 5 months ago (2016-06-27 14:20:49 UTC) #4
Jim Stichnoth
4 years, 5 months ago (2016-06-27 14:31:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f55d40577b013ee9ab9d8c838650e9f35cd0d1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698