Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2174)

Unified Diff: content/test/test_render_frame_host.cc

Issue 2099243002: PlzNavigate: properly set the initiator of the navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index c812ec8384e6e43dc2444def2b47cf613af90e84..02b50aed4633e8dc90409717703545e2be345a84 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -409,9 +409,10 @@ void TestRenderFrameHost::SendRendererInitiatedNavigationRequest(
InitializeRenderFrameIfNeeded();
if (IsBrowserSideNavigationEnabled()) {
- BeginNavigationParams begin_params(std::string(), net::LOAD_NORMAL,
- has_user_gesture, false,
- REQUEST_CONTEXT_TYPE_HYPERLINK);
+ // TODO(mkwst): The initiator origin here is incorrect.
+ BeginNavigationParams begin_params(
+ std::string(), net::LOAD_NORMAL, has_user_gesture, false,
+ REQUEST_CONTEXT_TYPE_HYPERLINK, url::Origin());
CommonNavigationParams common_params;
common_params.url = url;
common_params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault);
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698