content/browser/loader/resource_dispatcher_host_unittest.cc - Issue 2099243002: PlzNavigate: properly set the initiator of the navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 2099243002: PlzNavigate: properly set the initiator of the navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/service_worker/service_worker_fetch_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_unittest.cc

diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc

index 6c1a116dacb5b8773128363c82e9377fa2c33133..dcb94f75b8493dd710ad4644937edcbd0825fa77 100644

--- a/content/browser/loader/resource_dispatcher_host_unittest.cc

+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc

@@ -1083,13 +1083,14 @@ class ResourceDispatcherHostTest : public testing::TestWithParam<TestConfig>,

// Make a navigation request.

TestNavigationURLLoaderDelegate delegate;

BeginNavigationParams begin_params(std::string(), net::LOAD_NORMAL, false,

- false, REQUEST_CONTEXT_TYPE_LOCATION);

+ false, REQUEST_CONTEXT_TYPE_LOCATION,

+ url::Origin(url));

CommonNavigationParams common_params;

common_params.url = url;

std::unique_ptr<NavigationRequestInfo> request_info(

- new NavigationRequestInfo(

- common_params, begin_params, url, url::Origin(url), true, false,

- false, -1, false, false, blink::WebPageVisibilityStateVisible));

+ new NavigationRequestInfo(common_params, begin_params, url, true,

+ false, false, -1, false, false,

+ blink::WebPageVisibilityStateVisible));

std::unique_ptr<NavigationURLLoader> test_loader =

NavigationURLLoader::Create(browser_context_.get(),

std::move(request_info), nullptr, nullptr,

@@ -2640,13 +2641,13 @@ TEST_P(ResourceDispatcherHostTest, CancelRequestsForContext) {

// Create a NavigationRequest.

TestNavigationURLLoaderDelegate delegate;

BeginNavigationParams begin_params(std::string(), net::LOAD_NORMAL, false,

- false, REQUEST_CONTEXT_TYPE_LOCATION);

+ false, REQUEST_CONTEXT_TYPE_LOCATION,

+ url::Origin(download_url));

CommonNavigationParams common_params;

common_params.url = download_url;

std::unique_ptr<NavigationRequestInfo> request_info(

new NavigationRequestInfo(common_params, begin_params, download_url,

- url::Origin(download_url), true, false, false,

- -1, false, false,

+ true, false, false, -1, false, false,

blink::WebPageVisibilityStateVisible));

std::unique_ptr<NavigationURLLoader> loader = NavigationURLLoader::Create(

browser_context_.get(), std::move(request_info), nullptr, nullptr,