Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: content/test/test_render_frame_host.cc

Issue 2099243002: PlzNavigate: properly set the initiator of the navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index 115d6069a172c12b9e581da70aacecb2d527281a..6762125737bae5397c257926f6cd10bfd392162a 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -363,9 +363,10 @@ void TestRenderFrameHost::SendRendererInitiatedNavigationRequest(
InitializeRenderFrameIfNeeded();
if (IsBrowserSideNavigationEnabled()) {
- BeginNavigationParams begin_params(std::string(), net::LOAD_NORMAL,
- has_user_gesture, false,
- REQUEST_CONTEXT_TYPE_HYPERLINK);
+ // TODO(mkwst): The initiator origin here is incorrect.
+ BeginNavigationParams begin_params(
+ std::string(), net::LOAD_NORMAL, has_user_gesture, false,
+ REQUEST_CONTEXT_TYPE_HYPERLINK, url::Origin());
CommonNavigationParams common_params;
common_params.url = url;
common_params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault);
« content/common/navigation_params.h ('K') | « content/renderer/render_frame_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698