content/test/test_render_frame_host.cc - Issue 2099243002: PlzNavigate: properly set the initiator of the navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_frame_host.cc

Issue 2099243002: PlzNavigate: properly set the initiator of the navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | net/url_request/url_request_http_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/test_render_frame_host.cc

diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc

index c812ec8384e6e43dc2444def2b47cf613af90e84..02b50aed4633e8dc90409717703545e2be345a84 100644

--- a/content/test/test_render_frame_host.cc

+++ b/content/test/test_render_frame_host.cc

@@ -409,9 +409,10 @@ void TestRenderFrameHost::SendRendererInitiatedNavigationRequest(

InitializeRenderFrameIfNeeded();

if (IsBrowserSideNavigationEnabled()) {

- BeginNavigationParams begin_params(std::string(), net::LOAD_NORMAL,

- has_user_gesture, false,

- REQUEST_CONTEXT_TYPE_HYPERLINK);

+ // TODO(mkwst): The initiator origin here is incorrect.

+ BeginNavigationParams begin_params(

+ std::string(), net::LOAD_NORMAL, has_user_gesture, false,

+ REQUEST_CONTEXT_TYPE_HYPERLINK, url::Origin());

CommonNavigationParams common_params;

common_params.url = url;

common_params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault);

« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | net/url_request/url_request_http_job.cc » ('J')