PlzNavigate: properly set the initiator of the navigation

content/browser/loader/resource_dispatcher_host_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/resource_dispatcher_host.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "content/browser/download/download_manager_impl.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/resource_dispatcher_host_delegate.h"
 #include "content/public/browser/resource_request_info.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/browser/shell.h"
 #include "content/shell/browser/shell_content_browser_client.h"
 #include "content/shell/browser/shell_network_delegate.h"
 #include "net/base/net_errors.h"
@@ skipping 834 matching lines @@
   GURL top_url(embedded_test_server()->GetURL("/page_with_subresources.html"));
   url::Origin top_origin(top_url);
 
   NavigateToURLBlockUntilNavigationsComplete(shell(), top_url, 1);
 
   EXPECT_EQ(8u, delegate_->data().size());
 
   // All resources loaded directly by the top-level document (including the
   // top-level document itself) should have a |first_party| and |initiator|
   // that match the URL of the top-level document.
-  for (auto* request : delegate_->data()) {
-    SCOPED_TRACE(request->url);
-    EXPECT_EQ(top_url, request->first_party);
-    EXPECT_EQ(top_origin, request->initiator);
+  // PlzNavigate: the document itself should have an empty initiator.
+  if (IsBrowserSideNavigationEnabled()) {
+    const RequestDataForDelegate* first_request = delegate_->data()[0];
+    EXPECT_EQ(top_url, first_request->first_party);
+    EXPECT_FALSE(first_request->initiator.has_value());
+    for (size_t i = 1; i < delegate_->data().size(); i++) {
+      const RequestDataForDelegate* request = delegate_->data()[i];
+      EXPECT_EQ(top_url, request->first_party);
+      ASSERT_TRUE(request->initiator.has_value());
+      EXPECT_EQ(top_origin, request->initiator);
+    }
+  } else {
+    for (auto* request : delegate_->data()) {
+      SCOPED_TRACE(request->url);
+      EXPECT_EQ(top_url, request->first_party);
+      EXPECT_EQ(top_origin, request->initiator);
+    }
   }
 }
 
 IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest,
                        BasicCrossSite) {
   host_resolver()->AddRule("*", "127.0.0.1");
   GURL top_url(embedded_test_server()->GetURL(
       "a.com", "/nested_page_with_subresources.html"));
   GURL nested_url(embedded_test_server()->GetURL(
       "not-a.com", "/page_with_subresources.html"));
   url::Origin top_origin(top_url);
   url::Origin nested_origin(nested_url);
 
   NavigateToURLBlockUntilNavigationsComplete(shell(), top_url, 1);
 
   EXPECT_EQ(9u, delegate_->data().size());
 
   // The first items loaded are the top-level and nested documents. These should
   // both have a |first_party| and |initiator| that match the URL of the
-  // top-level document:
+  // top-level document.
+  // PlzNavigate: the top-level initiator is null.
   EXPECT_EQ(top_url, delegate_->data()[0]->url);
   EXPECT_EQ(top_url, delegate_->data()[0]->first_party);
-  EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  if (IsBrowserSideNavigationEnabled()) {
+    EXPECT_FALSE(delegate_->data()[0]->initiator.has_value());
+  } else {
+    ASSERT_TRUE(delegate_->data()[0]->initiator.has_value());
+    EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  }
 
   EXPECT_EQ(nested_url, delegate_->data()[1]->url);
   EXPECT_EQ(top_url, delegate_->data()[1]->first_party);
   EXPECT_EQ(top_origin, delegate_->data()[1]->initiator);
 
   // The remaining items are loaded as subresources in the nested document, and
   // should have a unique first-party, and an initiator that matches the
   // document in which they're embedded.
   for (size_t i = 2; i < delegate_->data().size(); i++) {
     SCOPED_TRACE(delegate_->data()[i]->url);
     EXPECT_EQ(kURLWithUniqueOrigin, delegate_->data()[i]->first_party);
     EXPECT_EQ(nested_origin, delegate_->data()[i]->initiator);
   }
 }
 
 IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest,
                        SameOriginNested) {
   GURL top_url(embedded_test_server()->GetURL("/page_with_iframe.html"));
   GURL image_url(embedded_test_server()->GetURL("/image.jpg"));
   GURL nested_url(embedded_test_server()->GetURL("/title1.html"));
   url::Origin top_origin(top_url);
 
   NavigateToURLBlockUntilNavigationsComplete(shell(), top_url, 1);
 
   EXPECT_EQ(3u, delegate_->data().size());
 
   // User-initiated top-level navigations have a first-party and initiator that
   // matches the URL to which they navigate.
+  // PlzNavigate: the top-level initiator is null.
   EXPECT_EQ(top_url, delegate_->data()[0]->url);
   EXPECT_EQ(top_url, delegate_->data()[0]->first_party);
-  EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  if (IsBrowserSideNavigationEnabled()) {
+    EXPECT_FALSE(delegate_->data()[0]->initiator.has_value());
+  } else {
+    ASSERT_TRUE(delegate_->data()[0]->initiator.has_value());
+    EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  }
 
   // Subresource requests have a first-party and initiator that matches the
   // document in which they're embedded.
   EXPECT_EQ(image_url, delegate_->data()[1]->url);
   EXPECT_EQ(top_url, delegate_->data()[1]->first_party);
   EXPECT_EQ(top_origin, delegate_->data()[1]->initiator);
 
   // Same-origin nested frames have a first-party and initiator that matches
   // the document in which they're embedded.
   EXPECT_EQ(nested_url, delegate_->data()[2]->url);
@@ skipping 16 matching lines @@
       "window.domAutomationController.send(clickSameSiteNewWindowLink());",
       &success));
   EXPECT_TRUE(success);
   Shell* new_shell = new_shell_observer.GetShell();
   WaitForLoadStop(new_shell->web_contents());
 
   EXPECT_EQ(2u, delegate_->data().size());
 
   // User-initiated top-level navigations have a first-party and initiator that
   // matches the URL to which they navigate, even if they fail to load.
+  // PlzNavigate: the top-level initiator is null.
   EXPECT_EQ(top_url, delegate_->data()[0]->url);
   EXPECT_EQ(top_url, delegate_->data()[0]->first_party);
-  EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  if (IsBrowserSideNavigationEnabled()) {
+    EXPECT_FALSE(delegate_->data()[0]->initiator.has_value());
+  } else {
+    ASSERT_TRUE(delegate_->data()[0]->initiator.has_value());
+    EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  }
 
   // Auxiliary navigations have a first-party that matches the URL to which they
   // navigate, and an initiator that matches the document that triggered them.
   EXPECT_EQ(auxiliary_url, delegate_->data()[1]->url);
   EXPECT_EQ(auxiliary_url, delegate_->data()[1]->first_party);
   EXPECT_EQ(top_origin, delegate_->data()[1]->initiator);
 }
 
 IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest,
                        CrossOriginAuxiliary) {
@@ skipping 18 matching lines @@
       "window.domAutomationController.send(clickCrossSiteNewWindowLink());",
       &success));
   EXPECT_TRUE(success);
   Shell* new_shell = new_shell_observer.GetShell();
   WaitForLoadStop(new_shell->web_contents());
 
   EXPECT_EQ(2u, delegate_->data().size());
 
   // User-initiated top-level navigations have a first-party and initiator that
   // matches the URL to which they navigate, even if they fail to load.
+  // PlzNavigate: the top-level initiator is null.
   EXPECT_EQ(top_url, delegate_->data()[0]->url);
   EXPECT_EQ(top_url, delegate_->data()[0]->first_party);
-  EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  if (IsBrowserSideNavigationEnabled()) {
+    EXPECT_FALSE(delegate_->data()[0]->initiator.has_value());
+  } else {
+    ASSERT_TRUE(delegate_->data()[0]->initiator.has_value());
+    EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  }
 
   // Auxiliary navigations have a first-party that matches the URL to which they
   // navigate, and an initiator that matches the document that triggered them.
   EXPECT_EQ(auxiliary_url, delegate_->data()[1]->url);
   EXPECT_EQ(auxiliary_url, delegate_->data()[1]->first_party);
   EXPECT_EQ(top_origin, delegate_->data()[1]->initiator);
 }
 
 IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest,
                        FailedNavigation) {
   // Navigating to this URL will fail, as we haven't taught the host resolver
   // about 'a.com'.
   GURL top_url(embedded_test_server()->GetURL("a.com", "/simple_page.html"));
   url::Origin top_origin(top_url);
 
   NavigateToURLBlockUntilNavigationsComplete(shell(), top_url, 1);
 
   EXPECT_EQ(1u, delegate_->data().size());
 
   // User-initiated top-level navigations have a first-party and initiator that
   // matches the URL to which they navigate, even if they fail to load.
+  // PlzNavigate: the top-level initiator is null.
   EXPECT_EQ(top_url, delegate_->data()[0]->url);
   EXPECT_EQ(top_url, delegate_->data()[0]->first_party);
-  EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  if (IsBrowserSideNavigationEnabled()) {
+    EXPECT_FALSE(delegate_->data()[0]->initiator.has_value());
+  } else {
+    ASSERT_TRUE(delegate_->data()[0]->initiator.has_value());
+    EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  }
 }
 
 IN_PROC_BROWSER_TEST_F(RequestDataResourceDispatcherHostBrowserTest,
                        CrossOriginNested) {
   host_resolver()->AddRule("*", "127.0.0.1");
   GURL top_url(embedded_test_server()->GetURL(
       "a.com", "/cross_site_iframe_factory.html?a(b)"));
   GURL top_js_url(
       embedded_test_server()->GetURL("a.com", "/tree_parser_util.js"));
   GURL nested_url(embedded_test_server()->GetURL(
       "b.com", "/cross_site_iframe_factory.html?b()"));
   GURL nested_js_url(
       embedded_test_server()->GetURL("b.com", "/tree_parser_util.js"));
   url::Origin top_origin(top_url);
   url::Origin nested_origin(nested_url);
 
   NavigateToURLBlockUntilNavigationsComplete(shell(), top_url, 1);
 
   EXPECT_EQ(4u, delegate_->data().size());
 
   // User-initiated top-level navigations have a first-party and initiator that
   // matches the URL to which they navigate.
+  // PlzNavigate: the top-level initiator is null.
   EXPECT_EQ(top_url, delegate_->data()[0]->url);
   EXPECT_EQ(top_url, delegate_->data()[0]->first_party);
-  EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  if (IsBrowserSideNavigationEnabled()) {
+    EXPECT_FALSE(delegate_->data()[0]->initiator.has_value());
+  } else {
+    ASSERT_TRUE(delegate_->data()[0]->initiator.has_value());
+    EXPECT_EQ(top_origin, delegate_->data()[0]->initiator);
+  }
 
   EXPECT_EQ(top_js_url, delegate_->data()[1]->url);
   EXPECT_EQ(top_url, delegate_->data()[1]->first_party);
   EXPECT_EQ(top_origin, delegate_->data()[1]->initiator);
 
   // Cross-origin frames have a first-party and initiator that matches the URL
   // in which they're embedded.
   EXPECT_EQ(nested_url, delegate_->data()[2]->url);
   EXPECT_EQ(top_url, delegate_->data()[2]->first_party);
   EXPECT_EQ(top_origin, delegate_->data()[2]->initiator);
 
   // Cross-origin subresource requests have a unique first-party, and an
   // initiator that matches the document in which they're embedded.
   EXPECT_EQ(nested_js_url, delegate_->data()[3]->url);
   EXPECT_EQ(kURLWithUniqueOrigin, delegate_->data()[3]->first_party);
   EXPECT_EQ(nested_origin, delegate_->data()[3]->initiator);
 }
 
 }  // namespace content