chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc - Issue 2099233003: Fix a crash due to the modal signin being closed before being shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

Issue 2099233003: Fix a crash due to the modal signin being closed before being shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

index 7d95a666ff0b34aaf901aa5506d96d013f404bd0..d85e39091424b0a2fbec5c6b34b98025da167fce 100644

--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

@@ -74,7 +74,8 @@ int SigninViewControllerDelegateViews::GetDialogButtons() const {

}

void SigninViewControllerDelegateViews::PerformClose() {

- modal_signin_widget_->Close();

+ if (modal_signin_widget_)

+ modal_signin_widget_->Close();

}

void SigninViewControllerDelegateViews::ResizeNativeView(int height) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »