telemetry/telemetry/benchmark.py - Issue 2099233002: [Telemetry] Default to tear down between page set repeats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/benchmark.py

Issue 2099233002: [Telemetry] Default to tear down between page set repeats (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/benchmark.py

diff --git a/telemetry/telemetry/benchmark.py b/telemetry/telemetry/benchmark.py

index 0e7a184b2bf39892af09bd71c48ec017bf656d1c..14770994203623c1613e36100112dc6c76bcf03a 100644

--- a/telemetry/telemetry/benchmark.py

+++ b/telemetry/telemetry/benchmark.py

@@ -126,10 +126,7 @@ class Benchmark(command_line.Command):

This should only be used by TimelineBasedMeasurement (TBM) benchmarks, but

not by PageTest based benchmarks.

"""

- # TODO(perezju): Switch default value after any benchmarks requiring the

- # old behaviour are updated accordingly.

- # https://github.com/catapult-project/catapult/issues/2294#issuecomment-228306977

- return False

+ return True

@classmethod

def AddCommandLineArgs(cls, parser):

« no previous file with comments | « no previous file | no next file » | no next file with comments »