Issue 20992005: Prepare some ValueOf renamings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20992005: Prepare some ValueOf renamings. (Closed)

Created:
7 years, 4 months ago by Sven Panne

Modified:
7 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare some ValueOf renamings. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15945

Patch Set 2 : Added comments #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -21 lines)			Patch
M	include/v8.h	View		5 chunks	+25 lines, -5 lines	0 comments	Download
M	src/api.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	7 chunks	+15 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a nit in the test-case). https://codereview.chromium.org/20992005/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/20992005/diff/1/test/cctest/test-api.cc#newcode1570 test/cctest/test-api.cc:1570: // CHECK(false_boolean_object->BooleanValue()); ...

7 years, 4 months ago (2013-07-29 14:26:58 UTC) #1

Sven Panne

7 years, 4 months ago (2013-07-30 07:05:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r15945 (presubmit successful).

Expand Messages | Collapse Messages

Issue 20992005: Prepare some ValueOf renamings. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added comments #

Messages