Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2099143002: X87: [turbofan] Prevent storing signalling NaNs into holey double arrays. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Prevent storing signalling NaNs into holey double arrays. port 6470ddadf93594657acee02b5ce5459752928490 (r36950) original commit message: This introduces SilenceNaN operator, which makes sure that we only store quiet NaNs into holey arrays. We omit the NaN silencing code at instruction selection time if the input is an operation that cannot possibly produce signalling NaNs. BUG= Committed: https://crrev.com/d0607218a06afbb630b53e5218b5e3fe287c69e4 Cr-Commit-Position: refs/heads/master@{#37265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 03:14:15 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 03:15:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099143002/1
4 years, 5 months ago (2016-06-27 03:16:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 03:38:28 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 03:39:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0607218a06afbb630b53e5218b5e3fe287c69e4
Cr-Commit-Position: refs/heads/master@{#37265}

Powered by Google App Engine
This is Rietveld 408576698