Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2099133002: Revert of aw: Try to turn crash into java exception (Closed)

Created:
4 years, 5 months ago by boliu
Modified:
4 years, 5 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of aw: Try to turn crash into java exception (patchset #1 id:1 of https://codereview.chromium.org/2076633002/ ) Reason for revert: Native crash still happens, which suggests mNativeAwContents being null is not the issue. Original issue's description: > aw: Try to turn crash into java exception > > Since I can't work out why things are null in native code anymore. > > BUG=618807 > > Committed: https://crrev.com/c731f40f3bfbcdd77bab19a0a45cd2f23e86bd6e > Cr-Commit-Position: refs/heads/master@{#400690} TBR=torne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618807 Committed: https://crrev.com/324e943d21ac3d2234730069644e847fe152a9a7 Cr-Commit-Position: refs/heads/master@{#402178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
boliu
Created Revert of aw: Try to turn crash into java exception
4 years, 5 months ago (2016-06-27 03:01:02 UTC) #1
boliu
The native crash still happens: https://crash.corp.google.com/browse?q=product.name%3D%27AndroidWebView%27%20AND%20product.version%3D%2752.0.2743.49%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27android_webview%3A%3AAwBrowserContext%3A%3AFromWebContents%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D I'm not any wiser what the actually issue is ...
4 years, 5 months ago (2016-06-27 03:02:26 UTC) #2
Torne
On 2016/06/27 03:02:26, boliu wrote: > The native crash still happens: > https://crash.corp.google.com/browse?q=product.name%3D%27AndroidWebView%27%20AND%20product.version%3D%2752.0.2743.49%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27android_webview%3A%3AAwBrowserContext%3A%3AFromWebContents%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D > > ...
4 years, 5 months ago (2016-06-27 11:51:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099133002/1
4 years, 5 months ago (2016-06-27 14:20:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 15:03:39 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 15:06:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/324e943d21ac3d2234730069644e847fe152a9a7
Cr-Commit-Position: refs/heads/master@{#402178}

Powered by Google App Engine
This is Rietveld 408576698