ash/shelf/overflow_button.h - Issue 2099103002: Give Ash material design tray items the correct size and layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/overflow_button.h

Issue 2099103002: Give Ash material design tray items the correct size and layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: split shelf and tray constants Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shelf/overflow_button.h

diff --git a/ash/shelf/overflow_button.h b/ash/shelf/overflow_button.h

index 4447d9c07433b6a904fe7043b0b7eb4b77c5dfb3..a101b3e87df72dd92e0026151893cb54d58b567b 100644

--- a/ash/shelf/overflow_button.h

+++ b/ash/shelf/overflow_button.h

@@ -42,8 +42,6 @@ class OverflowButton : public views::CustomButton {

int NonMaterialBackgroundImageId();

// Calculates the bounds of the overflow button based on the shelf alignment.

- // TODO(tdanderson): The button size and bounds need to be adjusted to

- // conform to the material design spec. See crbug.com/617295.

gfx::Rect CalculateButtonBounds();

// Used for bottom shelf alignment. |bottom_image_| points to

« no previous file with comments | « ash/shelf/app_list_button.cc ('k') | ash/shelf/overflow_button.cc » ('j') | no next file with comments »