src/elements.cc - Issue 209903003: Reland "Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.cc

Issue 209903003: Reland "Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/elements.cc

diff --git a/src/elements.cc b/src/elements.cc

index 1ddc69dde02730f13da35dcb2cfa11694d9bc918..527df6e3d753cf9386839413d78dc5f9a610447b 100644

--- a/src/elements.cc

+++ b/src/elements.cc

@@ -318,7 +318,7 @@ MUST_USE_RESULT static MaybeObject* CopyDoubleToObjectElements(

// that no GC is triggered, allocate HeapNumbers from old space if they

// can't be taken from new space.

if (!maybe_value->ToObject(&value)) {

- ASSERT(maybe_value->IsRetryAfterGC() || maybe_value->IsOutOfMemory());

+ ASSERT(maybe_value->IsRetryAfterGC());

Heap* heap = from->GetHeap();

MaybeObject* maybe_value_object =

heap->AllocateHeapNumber(from->get_scalar(i + from_start),

« no previous file with comments | « src/contexts.h ('k') | src/execution.cc » ('j') | no next file with comments »