Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 209903002: Revert of aura: Remove old GL paths from RenderWidgetHostViewAura. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Revert of aura: Remove old GL paths from RenderWidgetHostViewAura. (https://codereview.chromium.org/131443007/) Reason for revert: This is causing many virtual/threaded/transitions and virtual/threaded/animations tests to time out. Some of them are timing out flakily, some are consistent. Here is what I’ve seen so far: virtual/threaded/transitions/move-after-transition.html - consistent time outs. virtual/threaded/transitions/cubic-bezier-overflow-svg-length.html - flaky time outs virtual/threaded/transitions/change-duration-during-transition.html - flaky time outs virtual/threaded/animations/cross-fade-background-image.html - flaky ImageOnlyFailure, looks like it is related. Original issue's description: > aura: Remove old GL paths from RenderWidgetHostViewAura. > > Frames from the renderer are either legacy software, > software compositing, or ubercomp. Remove the old GL composited > paths that are no longer in use. > > For layout tests, put them into composited mailbox mode, and > instead of sending the frame to the browser at all, just put the > frame in a post task to ack back directly to the renderer. > > R=piman > BUG=332998 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249226 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258742 TBR=piman@chromium.org,fsamuel@chromium.org,phajdan.jr@chromium.org,jamesr@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=332998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -117 lines) Patch
M chrome/browser/about_flags.cc View 5 chunks +4 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 8 chunks +44 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 23 chunks +349 lines, -27 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 5 chunks +82 lines, -9 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 4 chunks +0 lines, -11 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 2 chunks +4 lines, -44 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
Created Revert of aura: Remove old GL paths from RenderWidgetHostViewAura.
6 years, 9 months ago (2014-03-24 08:42:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/209903002/1
6 years, 9 months ago (2014-03-24 08:42:01 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 08:42:52 UTC) #3
Message was sent while issue was closed.
Change committed as 258891

Powered by Google App Engine
This is Rietveld 408576698