Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2405)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 2099003002: build tweaks for cfi Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/sanitizers/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index afedebc8591906544b5cabfea6bcdab0ed15925c..461b30f983d1184c548f3464dcbef3260fc56020 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -462,11 +462,8 @@ config("compiler") {
ldflags += [ "-Wl,-plugin-opt,-function-sections" ]
}
- # TODO(pcc): Make these flags work correctly with CFI.
- if (!is_cfi) {
- cflags += [ "-fwhole-program-vtables" ]
- ldflags += [ "-fwhole-program-vtables" ]
- }
+ cflags += [ "-fwhole-program-vtables" ]
+ ldflags += [ "-fwhole-program-vtables" ]
}
# Pass the same C/C++ flags to the objective C/C++ compiler.
« no previous file with comments | « no previous file | build/config/sanitizers/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698