Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2098963002: Remove uninit read suppression for Mojo EDK writes (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
CC:
bruening+watch_chromium.org, chromium-reviews, glider+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uninit read suppression for Mojo EDK writes This is a common codepath through which all IPC data is transmitted. Suppressing this supresses all potential uninitialized read bugs in any code which prepares IPC messages for transit (e.g. any IPC::ParamTraits implementation.) This suppression was recently relanded as a result of an uninitialized read in some IPC message contents. It's possible that the actual bug has been fixed, but it's unclear. Since I'm unable to repro locally I'm removing the suppression to see if the memory bots go red again. Memory sheriffs *please* ping rockot@ before relanding this suppression. BUG=398547, 623235 TBR=amistry@chromium.org Committed: https://crrev.com/bf1598991bbbf0a9b34764a37a9c1b97ea50ca4f Cr-Commit-Position: refs/heads/master@{#402013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098963002/1
4 years, 6 months ago (2016-06-24 22:49:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 23:33:56 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 23:37:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf1598991bbbf0a9b34764a37a9c1b97ea50ca4f
Cr-Commit-Position: refs/heads/master@{#402013}

Powered by Google App Engine
This is Rietveld 408576698